Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b08d8d26 authored by Ricardo Ribalda Delgado's avatar Ricardo Ribalda Delgado Committed by Mauro Carvalho Chehab
Browse files

[media] media/v4l2-ctrls: volatiles should not generate CH_VALUE 



Volatile controls should not generate CH_VALUE events.

Set has_changed to false to prevent this happening.

Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 5190931d

drivers/media/v4l2-core/v4l2-ctrls.c

+9 −0
Original line number Original line Diff line number Diff line
@@ -1609,6 +1609,15 @@ static int cluster_changed(struct v4l2_ctrl *master) 




		if (ctrl == NULL)

		if (ctrl == NULL)

			continue;

			continue;

		/*

		 * Set has_changed to false to avoid generating

		 * the event V4L2_EVENT_CTRL_CH_VALUE

		 */

		if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE) {

			ctrl->has_changed = false;

			continue;

		}



		for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)

		for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)

			ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,

			ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,

				ctrl->p_cur, ctrl->p_new);

				ctrl->p_cur, ctrl->p_new);