Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aea7ccd9 authored by Niu Yawei's avatar Niu Yawei Committed by Greg Kroah-Hartman
Browse files

staging/lustre/mdc: Zero atime in close RPC 



While atime on close is supposed to only increase, there's
a bug in some older server versions where atime from a client
is taken no matter the value that allows a stale client atime
to overwrite a correct value.

Update atime in close rpc to 0 to help such servers out.

Signed-off-by: default avatarNiu Yawei <yawei.niu@intel.com>
Reviewed-on: http://review.whamcloud.com/19932
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8041


Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Reviewed-by: default avatarJinshan Xiong <jinshan.xiong@intel.com>
Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2323d6d8

drivers/staging/lustre/lustre/mdc/mdc_lib.c

+12 −0
Original line number Original line Diff line number Diff line
@@ -467,6 +467,18 @@ void mdc_close_pack(struct ptlrpc_request *req, struct md_op_data *op_data) 
	rec = req_capsule_client_get(&req->rq_pill, &RMF_REC_REINT);

	rec = req_capsule_client_get(&req->rq_pill, &RMF_REC_REINT);





	mdc_setattr_pack_rec(rec, op_data);

	mdc_setattr_pack_rec(rec, op_data);

	/*

	 * The client will zero out local timestamps when losing the IBITS lock

	 * so any new RPC timestamps will update the client inode's timestamps.

	 * There was a defect on the server side which allowed the atime to be

	 * overwritten by a zeroed-out atime packed into the close RPC.

	 *

	 * Proactively clear the MDS_ATTR_ATIME flag in the RPC in this case

	 * to avoid zeroing the atime on old unpatched servers.  See LU-8041.

	 */

	if (rec->sa_atime == 0)

		rec->sa_valid &= ~MDS_ATTR_ATIME;



	mdc_ioepoch_pack(epoch, op_data);

	mdc_ioepoch_pack(epoch, op_data);

	mdc_hsm_release_pack(req, op_data);

	mdc_hsm_release_pack(req, op_data);

}

}