Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae190f04 authored by Ondrej Mosnacek's avatar Ondrej Mosnacek Committed by Greg Kroah-Hartman
Browse files

selinux: fix memory leak in policydb_init() 



commit 45385237f65aeee73641f1ef737d7273905a233f upstream.

Since roles_init() adds some entries to the role hash table, we need to
destroy also its keys/values on error, otherwise we get a memory leak in
the error path.

Cc: <stable@vger.kernel.org>
Reported-by: default avatar <syzbot+fee3a14d4cdf92646287@syzkaller.appspotmail.com>
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarOndrej Mosnacek <omosnace@redhat.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7b185859

security/selinux/ss/policydb.c

+5 −1
Original line number Diff line number Diff line
@@ -266,6 +266,8 @@ static int rangetr_cmp(struct hashtab *h, const void *k1, const void *k2) 
	return v;

}



static int (*destroy_f[SYM_NUM]) (void *key, void *datum, void *datap);



/*

 * Initialize a policy database structure.

 */
@@ -313,8 +315,10 @@ static int policydb_init(struct policydb *p) 
out:

	hashtab_destroy(p->filename_trans);

	hashtab_destroy(p->range_tr);

	for (i = 0; i < SYM_NUM; i++)

	for (i = 0; i < SYM_NUM; i++) {

		hashtab_map(p->symtab[i].table, destroy_f[i], NULL);

		hashtab_destroy(p->symtab[i].table);

	}

	return rc;

}