Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adcb2623 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / cpuidle: Clean up fallback to C1 checks 



acpi_idle_enter_simple() and acpi_idle_enter_bm() both check
if C2/C3 type entry is supported on MP in the same way, so move
those checks to a separate function and call it from both
places (and it doesn't need to check if the state type is not
C1, because the functions in question won't be called otherwise).

While at it, use IS_ENABLED() for the CONFIG_HOTPLUG_CPU check.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 67f592c8

drivers/acpi/processor_idle.c

+9 −10
Original line number Original line Diff line number Diff line
@@ -758,6 +758,13 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) 
	return 0;

	return 0;

}

}





static bool acpi_idle_fallback_to_c1(struct acpi_processor *pr)

{

	return IS_ENABLED(CONFIG_HOTPLUG_CPU) && num_online_cpus() > 1 &&

		!(acpi_gbl_FADT.flags & ACPI_FADT_C2_MP_SUPPORTED) &&

		!pr->flags.has_cst;

}



/**

/**

 * acpi_idle_enter_simple - enters an ACPI state without BM handling

 * acpi_idle_enter_simple - enters an ACPI state without BM handling

 * @dev: the target CPU

 * @dev: the target CPU
@@ -775,12 +782,8 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev, 
	if (unlikely(!pr))

	if (unlikely(!pr))

		return -EINVAL;

		return -EINVAL;





#ifdef CONFIG_HOTPLUG_CPU

	if (acpi_idle_fallback_to_c1(pr))

	if ((cx->type != ACPI_STATE_C1) && (num_online_cpus() > 1) &&

	    !pr->flags.has_cst &&

	    !(acpi_gbl_FADT.flags & ACPI_FADT_C2_MP_SUPPORTED))

		return acpi_idle_enter_c1(dev, drv, CPUIDLE_DRIVER_STATE_START);

		return acpi_idle_enter_c1(dev, drv, CPUIDLE_DRIVER_STATE_START);

#endif





	/*

	/*

	 * Must be done before busmaster disable as we might need to

	 * Must be done before busmaster disable as we might need to
@@ -819,12 +822,8 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev, 
	if (unlikely(!pr))

	if (unlikely(!pr))

		return -EINVAL;

		return -EINVAL;





#ifdef CONFIG_HOTPLUG_CPU

	if (acpi_idle_fallback_to_c1(pr))

	if ((cx->type != ACPI_STATE_C1) && (num_online_cpus() > 1) &&

	    !pr->flags.has_cst &&

	    !(acpi_gbl_FADT.flags & ACPI_FADT_C2_MP_SUPPORTED))

		return acpi_idle_enter_c1(dev, drv, CPUIDLE_DRIVER_STATE_START);

		return acpi_idle_enter_c1(dev, drv, CPUIDLE_DRIVER_STATE_START);

#endif





	if (!cx->bm_sts_skip && acpi_idle_bm_check()) {

	if (!cx->bm_sts_skip && acpi_idle_bm_check()) {

		if (drv->safe_state_index >= 0) {

		if (drv->safe_state_index >= 0) {