Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adcb0fa2 authored by Adrian Bunk's avatar Adrian Bunk Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (3963): Em28xx/: possible cleanups 



This patch contains the following possible cleanups:
- make the following needlessly global functions static:
  - em28xx-core.c: em28xx_accumulator_set()
  - em28xx-core.c: em28xx_capture_area_set()
  - em28xx-core.c: em28xx_scaler_set()
  - em28xx-core.c: em28xx_isocIrq()
- remove the following unused EXPORT_SYMBOL's:
  - em28xx-cards.c: em28xx_boards
  - em28xx-cards.c: em28xx_bcount
  - em28xx-cards.c: em28xx_id_table

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent a9686e0d

drivers/media/video/em28xx/em28xx-cards.c

+0 −4
Original line number Diff line number Diff line
@@ -326,8 +326,4 @@ void em28xx_card_setup(struct em28xx *dev) 
	}

}



EXPORT_SYMBOL(em28xx_boards);

EXPORT_SYMBOL(em28xx_bcount);

EXPORT_SYMBOL(em28xx_id_table);



MODULE_DEVICE_TABLE (usb, em28xx_id_table);

drivers/media/video/em28xx/em28xx-core.c

+5 −5
Original line number Diff line number Diff line
@@ -317,8 +317,8 @@ int em28xx_outfmt_set_yuv422(struct em28xx *dev) 
	return em28xx_write_regs(dev, VINCTRL_REG, "\x11", 1);

}



int em28xx_accumulator_set(struct em28xx *dev, u8 xmin, u8 xmax, u8 ymin,

				  u8 ymax)

static int em28xx_accumulator_set(struct em28xx *dev, u8 xmin, u8 xmax,

				  u8 ymin, u8 ymax)

{

	em28xx_coredbg("em28xx Scale: (%d,%d)-(%d,%d)\n", xmin, ymin, xmax, ymax);
@@ -328,7 +328,7 @@ int em28xx_accumulator_set(struct em28xx *dev, u8 xmin, u8 xmax, u8 ymin, 
	return em28xx_write_regs(dev, YMAX_REG, &ymax, 1);

}



int em28xx_capture_area_set(struct em28xx *dev, u8 hstart, u8 vstart,

static int em28xx_capture_area_set(struct em28xx *dev, u8 hstart, u8 vstart,

				   u16 width, u16 height)

{

	u8 cwidth = width;
@@ -345,7 +345,7 @@ int em28xx_capture_area_set(struct em28xx *dev, u8 hstart, u8 vstart, 
	return em28xx_write_regs(dev, OFLOW_REG, &overflow, 1);

}



int em28xx_scaler_set(struct em28xx *dev, u16 h, u16 v)

static int em28xx_scaler_set(struct em28xx *dev, u16 h, u16 v)

{

	u8 mode;

	/* the em2800 scaler only supports scaling down to 50% */
@@ -534,7 +534,7 @@ static inline void em28xx_isoc_video_copy(struct em28xx *dev, 
 * em28xx_isoIrq()

 * handles the incoming isoc urbs and fills the frames from our inqueue

 */

void em28xx_isocIrq(struct urb *urb, struct pt_regs *regs)

static void em28xx_isocIrq(struct urb *urb, struct pt_regs *regs)

{

	struct em28xx *dev = urb->context;

	int i, status;

drivers/media/video/em28xx/em28xx.h

+0 −6
Original line number Diff line number Diff line
@@ -319,13 +319,7 @@ int em28xx_audio_analog_set(struct em28xx *dev); 
int em28xx_colorlevels_set_default(struct em28xx *dev);

int em28xx_capture_start(struct em28xx *dev, int start);

int em28xx_outfmt_set_yuv422(struct em28xx *dev);

int em28xx_accumulator_set(struct em28xx *dev, u8 xmin, u8 xmax, u8 ymin,

			   u8 ymax);

int em28xx_capture_area_set(struct em28xx *dev, u8 hstart, u8 vstart,

			    u16 width, u16 height);

int em28xx_scaler_set(struct em28xx *dev, u16 h, u16 v);

int em28xx_resolution_set(struct em28xx *dev);

void em28xx_isocIrq(struct urb *urb, struct pt_regs *regs);

int em28xx_init_isoc(struct em28xx *dev);

void em28xx_uninit_isoc(struct em28xx *dev);

int em28xx_set_alternate(struct em28xx *dev);