Commit ad4e1a7c authored Feb 17, 2013 by Haojian Zhuang Committed by Linus Walleij Mar 07, 2013

gpio: fix wrong checking condition for gpio range



If index++ calculates from 0, the checking condition of "while
(index++)" fails & it doesn't check any more. It doesn't follow
the loop that used at here.

Replace it by endless loop at here. Then it keeps parsing
"gpio-ranges" property until it ends.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 6dbe51c2

drivers/gpio/gpiolib-of.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -193,7 +193,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
		if (!np)
		return;

		do {
		for (;; index++) {
		ret = of_parse_phandle_with_args(np, "gpio-ranges",
		"#gpio-range-cells", index, &pinspec);
		if (ret)
		@@ -222,8 +222,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)

		if (ret)
		break;

		} while (index++);
		}
		}

		#else