Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad3f428e authored by Shlomo Pongratz's avatar Shlomo Pongratz Committed by James Bottomley
Browse files

[SCSI] be2iscsi: Fix possible reentrancy issue in be_iopoll



The driver creates "NAPI" context per core which is fine,
however the above routine declares the ret variable as static!
Thus there is only one instance of this variable!
When this routine is called from more than one thread of execution,
than the result is unpredictable.

         static unsigned int ret;
         .....

         ret = beiscsi_process_cq(pbe_eq);
                 <--------Another thread can enter here and change "ret".
         if (ret < budget) {
                ....
         }
                 <--------Another thread can enter here and change "ret".
         return ret;

Fix - remove the "static"

Signed-off-by: default avatarShlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: default avatarJayamohan Kallickal <jayamohan.kallickal@emulex.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 533c165f
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -2191,7 +2191,7 @@ void beiscsi_process_all_cqs(struct work_struct *work)

static int be_iopoll(struct blk_iopoll *iop, int budget)
{
	static unsigned int ret;
	unsigned int ret;
	struct beiscsi_hba *phba;
	struct be_eq_obj *pbe_eq;