Commit ad0ea198 authored Mar 22, 2016 by Paolo Abeni Committed by David S. Miller Mar 22, 2016

ipv4: fix broadcast packets reception



Currently, ingress ipv4 broadcast datagrams are dropped since,
in udp_v4_early_demux(), ip_check_mc_rcu() is invoked even on
bcast packets.

This patch addresses the issue, invoking ip_check_mc_rcu()
only for mcast packets.

Fixes: 6e540309 ("ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0419f4a9

net/ipv4/udp.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -2070,10 +2070,14 @@ void udp_v4_early_demux(struct sk_buff *skb)
		if (!in_dev)
		return;

		/* we are supposed to accept bcast packets */
		if (skb->pkt_type == PACKET_MULTICAST) {
		ours = ip_check_mc_rcu(in_dev, iph->daddr, iph->saddr,
		iph->protocol);
		if (!ours)
		return;
		}

		sk = __udp4_lib_mcast_demux_lookup(net, uh->dest, iph->daddr,
		uh->source, iph->saddr, dif);
		} else if (skb->pkt_type == PACKET_HOST) {