Commit ace22170 authored Sep 30, 2015 by Axel Lin Committed by Greg Kroah-Hartman Oct 04, 2015

nvmem: core: Fix memory leak in nvmem_cell_write

A tmp buffer is allocated if cell->bit_offset || cell->nbits.
So the tmp buffer needs to be freed at the same condition to avoid leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cbf854ab

drivers/nvmem/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -938,7 +938,7 @@ int nvmem_cell_write(struct nvmem_cell cell, void buf, size_t len)
		rc = regmap_raw_write(nvmem->regmap, cell->offset, buf, cell->bytes);

		/* free the tmp buffer */
		if (cell->bit_offset)
		if (cell->bit_offset \|\| cell->nbits)
		kfree(buf);

		if (IS_ERR_VALUE(rc))