Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acd61451 authored by Dimitris Papastamos's avatar Dimitris Papastamos Committed by Mark Brown
Browse files

ASoC: soc-cache: Return -ENOSYS instead of -EINVAL 



These functions fail with -EINVAL if the corresponding callbacks
are not implemented.  Change them to return -ENOSYS as it is more
appropriate for unimplemented callbacks.

Signed-off-by: default avatarDimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <lrg@ti.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 30539a18

sound/soc/soc-cache.c

+5 −5
Original line number Diff line number Diff line
@@ -1295,7 +1295,7 @@ int snd_soc_cache_init(struct snd_soc_codec *codec) 
				codec->cache_ops->name, codec->name);

		return codec->cache_ops->init(codec);

	}

	return -EINVAL;

	return -ENOSYS;

}



/*
@@ -1310,7 +1310,7 @@ int snd_soc_cache_exit(struct snd_soc_codec *codec) 
				codec->cache_ops->name, codec->name);

		return codec->cache_ops->exit(codec);

	}

	return -EINVAL;

	return -ENOSYS;

}



/**
@@ -1334,7 +1334,7 @@ int snd_soc_cache_read(struct snd_soc_codec *codec, 
	}



	mutex_unlock(&codec->cache_rw_mutex);

	return -EINVAL;

	return -ENOSYS;

}

EXPORT_SYMBOL_GPL(snd_soc_cache_read);
@@ -1359,7 +1359,7 @@ int snd_soc_cache_write(struct snd_soc_codec *codec, 
	}



	mutex_unlock(&codec->cache_rw_mutex);

	return -EINVAL;

	return -ENOSYS;

}

EXPORT_SYMBOL_GPL(snd_soc_cache_write);
@@ -1382,7 +1382,7 @@ int snd_soc_cache_sync(struct snd_soc_codec *codec) 
	}



	if (!codec->cache_ops || !codec->cache_ops->sync)

		return -EINVAL;

		return -ENOSYS;



	if (codec->cache_ops->name)

		name = codec->cache_ops->name;