Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abac5bac authored by Markus Elfring's avatar Markus Elfring Committed by Vinod Koul
Browse files

ste_dma40: Move an assignment in d40_lcla_allocate() 



Move one assignment for the local variable "ret" so that its setting
will only be performed after corresponding data processing succeeded
by this function.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent aae32ec6

drivers/dma/ste_dma40.c

+2 −1
Original line number Diff line number Diff line
@@ -3404,7 +3404,7 @@ static int __init d40_lcla_allocate(struct d40_base *base) 
	struct d40_lcla_pool *pool = &base->lcla_pool;

	unsigned long *page_list;

	int i, j;

	int ret = 0;

	int ret;



	/*

	 * This is somewhat ugly. We need 8192 bytes that are 18 bit aligned,
@@ -3476,6 +3476,7 @@ static int __init d40_lcla_allocate(struct d40_base *base) 


	writel(virt_to_phys(base->lcla_pool.base),

	       base->virtbase + D40_DREG_LCLA);

	ret = 0;

 free_page_list:

	kfree(page_list);

	return ret;