Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab74b3d6 authored by Steve Hodgson's avatar Steve Hodgson Committed by Nicholas Bellinger
Browse files

target: Fix incorrect usage of nested IRQ spinlocks in ABORT_TASK path 



This patch changes core_tmr_abort_task() to use spin_lock -> spin_unlock
around se_cmd->t_state_lock while spin_lock_irqsave is held via
se_sess->sess_cmd_lock.

Signed-off-by: default avatarSteve Hodgson <steve@purestorage.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent d5627acb

drivers/target/target_core_tmr.c

+3 −3
Original line number Diff line number Diff line
@@ -140,15 +140,15 @@ void core_tmr_abort_task( 
		printk("ABORT_TASK: Found referenced %s task_tag: %u\n",

			se_cmd->se_tfo->get_fabric_name(), ref_tag);



		spin_lock_irq(&se_cmd->t_state_lock);

		spin_lock(&se_cmd->t_state_lock);

		if (se_cmd->transport_state & CMD_T_COMPLETE) {

			printk("ABORT_TASK: ref_tag: %u already complete, skipping\n", ref_tag);

			spin_unlock_irq(&se_cmd->t_state_lock);

			spin_unlock(&se_cmd->t_state_lock);

			spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);

			goto out;

		}

		se_cmd->transport_state |= CMD_T_ABORTED;

		spin_unlock_irq(&se_cmd->t_state_lock);

		spin_unlock(&se_cmd->t_state_lock);



		list_del_init(&se_cmd->se_cmd_list);

		kref_get(&se_cmd->cmd_kref);