Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab4db1f2 authored by Catalin Marinas's avatar Catalin Marinas Committed by Will Deacon
Browse files

arm64: Replace hard-coded values in the pmd/pud_bad() macros 



This patch replaces the hard-coded value 2 with PMD_TABLE_BIT in the
pmd/pud_bad() macros. Note that using these macros on pmd_trans_huge()
entries is giving incorrect results
(pmd_none_or_trans_huge_or_clear_bad() correctly checks for
pmd_trans_huge before pmd_bad).

Additionally, white-space clean-up for pmd_mkclean().

Reviewed-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 282aa705

arch/arm64/include/asm/pgtable.h

+3 −3
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ extern pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, 
#define pmd_none(pmd)		(!pmd_val(pmd))

#define pmd_present(pmd)	(pmd_val(pmd))



#define pmd_bad(pmd)		(!(pmd_val(pmd) & 2))

#define pmd_bad(pmd)		(!(pmd_val(pmd) & PMD_TABLE_BIT))



#define pmd_table(pmd)		((pmd_val(pmd) & PMD_TYPE_MASK) == \

				 PMD_TYPE_TABLE)
@@ -403,7 +403,7 @@ static inline phys_addr_t pmd_page_paddr(pmd_t pmd) 
#define pmd_ERROR(pmd)		__pmd_error(__FILE__, __LINE__, pmd_val(pmd))



#define pud_none(pud)		(!pud_val(pud))

#define pud_bad(pud)		(!(pud_val(pud) & 2))

#define pud_bad(pud)		(!(pud_val(pud) & PUD_TABLE_BIT))

#define pud_present(pud)	(pud_val(pud))



static inline void set_pud(pud_t *pudp, pud_t pud)