Commit ab2b7eba authored May 26, 2009 by Tetsuo Handa Committed by Linus Torvalds May 26, 2009

kmod: Release sub_info on cred allocation failure.



call_usermodehelper_setup() forgot to kfree(sub_info)
when prepare_usermodehelper_creds() failed.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d4a76f8a

kernel/kmod.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -370,8 +370,10 @@ struct subprocess_info call_usermodehelper_setup(char path, char **argv,
		sub_info->argv = argv;
		sub_info->envp = envp;
		sub_info->cred = prepare_usermodehelper_creds();
		if (!sub_info->cred)
		if (!sub_info->cred) {
		kfree(sub_info);
		return NULL;
		}

		out:
		return sub_info;