Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab130961 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Dave Airlie
Browse files

drm/sysfs: Remove stale comments about calling drm_sysfs_connector_add() multiple times 



drm_connector_sysfs_add() explicitly checks if connector->kdev
is already populated and returns success. So it clearly now allows
being called multiple times. Remove some stale comments to the contrary.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 721529b5

drivers/gpu/drm/drm_sysfs.c

+0 −6
Original line number Diff line number Diff line
@@ -366,11 +366,6 @@ static struct bin_attribute edid_attr = { 
 * properties (so far, connection status, dpms, mode list & edid) and

 * generate a hotplug event so userspace knows there's a new connector

 * available.

 *

 * Note:

 * This routine should only be called *once* for each registered connector.

 * A second call for an already registered connector will trigger the BUG_ON

 * below.

 */

int drm_sysfs_connector_add(struct drm_connector *connector)

{
@@ -383,7 +378,6 @@ int drm_sysfs_connector_add(struct drm_connector *connector) 
	if (connector->kdev)

		return 0;



	/* We shouldn't get called more than once for the same connector */

	connector->kdev = device_create(drm_class, dev->primary->kdev,

					0, connector, "card%d-%s",

					dev->primary->index, drm_get_connector_name(connector));