Commit aa9ddcd4 authored Aug 02, 2012 by Josef Bacik Committed by Chris Mason Aug 28, 2012

Btrfs: do not use missing devices when showing devname



If you do the following

mkfs.btrfs /dev/sdb /dev/sdc
rmmod btrfs
dd if=/dev/zero of=/dev/sdb bs=1M count=1
mount -o degraded /dev/sdc /mnt/btrfs-test

the box will panic trying to deref the name for the missing dev since it is
the lower numbered devid.  So fix show_devname to not use missing devices.
Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>

parent 3627bf45

fs/btrfs/super.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1505,6 +1505,8 @@ static int btrfs_show_devname(struct seq_file m, struct dentry root)
		while (cur_devices) {
		head = &cur_devices->devices;
		list_for_each_entry(dev, head, dev_list) {
		if (dev->missing)
		continue;
		if (!first_dev \|\| dev->devid < first_dev->devid)
		first_dev = dev;
		}