Commit aa91c4d8 authored Jul 31, 2012 by Jan Kara Committed by Linus Torvalds Jul 31, 2012

mm: make vb_alloc() more foolproof



If someone calls vb_alloc() (or vm_map_ram() for that matter) to allocate
0 bytes (0 pages), get_order() returns BITS_PER_LONG - PAGE_CACHE_SHIFT
and interesting stuff happens.  So make debugging such problems easier and
warn about 0-size allocation.

[akpm@linux-foundation.org: use WARN_ON-return-value feature]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 92ca922f

mm/vmalloc.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -904,6 +904,14 @@ static void *vb_alloc(unsigned long size, gfp_t gfp_mask)

		BUG_ON(size & ~PAGE_MASK);
		BUG_ON(size > PAGE_SIZE*VMAP_MAX_ALLOC);
		if (WARN_ON(size == 0)) {
		/*
		* Allocating 0 bytes isn't what caller wants since
		* get_order(0) returns funny result. Just warn and terminate
		* early.
		*/
		return NULL;
		}
		order = get_order(size);

		again: