Commit aa5e5cea authored May 13, 2008 by David Miller Committed by Thomas Gleixner May 23, 2008

ftrace: remove packed attribute on ftrace_page.



It causes unaligned access traps on platforms like sparc
(ftrace_page may be marked packed, but once we return
a dyn_ftrace sub-object from this array to another piece
of code, the "packed" part of the typing information doesn't
propagate).

But also, it didn't serve any purpose either.  Even if packed,
on 64-bit or 32-bit, it didn't give us any more dyn_ftrace
entries per-page.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 74f4e369

kernel/trace/ftrace.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -177,9 +177,9 @@ static DEFINE_MUTEX(ftrace_filter_lock);

		struct ftrace_page {
		struct ftrace_page *next;
		int index;
		unsigned long index;
		struct dyn_ftrace records[];
		} __attribute__((packed));
		};

		#define ENTRIES_PER_PAGE \
		((PAGE_SIZE - sizeof(struct ftrace_page)) / sizeof(struct dyn_ftrace))