Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa5affba authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by John W. Linville
Browse files

iwlwifi: dump stack when fail to gain access to the device 



Print dump stack when the device is not responding. This should give
some more clue about the reason of failure. Also change the message we
print, since "MAC in deep sleep" is kinda confusing.

On the way add unlikely(), as fail to gain NIC access is hmm ...
unlikely.

Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9441b85d

drivers/net/wireless/iwlwifi/iwl-io.c

+3 −3
Original line number Diff line number Diff line
@@ -121,10 +121,10 @@ int iwl_grab_nic_access_silent(struct iwl_trans *trans) 
int iwl_grab_nic_access(struct iwl_trans *trans)

{

	int ret = iwl_grab_nic_access_silent(trans);

	if (ret) {

	if (unlikely(ret)) {

		u32 val = iwl_read32(trans, CSR_GP_CNTRL);

		IWL_ERR(trans,

			"MAC is in deep sleep!. CSR_GP_CNTRL = 0x%08X\n", val);

		WARN_ONCE(1, "Timeout waiting for hardware access "

			     "(CSR_GP_CNTRL 0x%08x)\n", val);

	}



	return ret;