Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9febbb4 authored by Eric Dumazet's avatar Eric Dumazet Committed by Linus Torvalds
Browse files

sysctl: min/max bounds are optional 



sysctl check complains with a WARN() when proc_doulongvec_minmax() or
proc_doulongvec_ms_jiffies_minmax() are used by a vector of longs (with
more than one element), with no min or max value specified.

This is unexpected, given we had a bug on this min/max handling :)

Reported-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Miller <davem@davemloft.net>
Acked-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5a2b3ef4

kernel/sysctl_check.c

+0 −9
Original line number Diff line number Diff line
@@ -143,15 +143,6 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) 
				if (!table->maxlen)

					set_fail(&fail, table, "No maxlen");

			}

			if ((table->proc_handler == proc_doulongvec_minmax) ||

			    (table->proc_handler == proc_doulongvec_ms_jiffies_minmax)) {

				if (table->maxlen > sizeof (unsigned long)) {

					if (!table->extra1)

						set_fail(&fail, table, "No min");

					if (!table->extra2)

						set_fail(&fail, table, "No max");

				}

			}

#ifdef CONFIG_PROC_SYSCTL

			if (table->procname && !table->proc_handler)

				set_fail(&fail, table, "No proc_handler");