Commit a9c930ba authored Feb 20, 2006 by Andi Kleen Committed by Linus Torvalds Feb 20, 2006

[PATCH] Fix units in mbind check



maxnode is a bit index and can't be directly compared against a byte length
like PAGE_SIZE

Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent c255d844

mm/mempolicy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -808,7 +808,7 @@ static int get_nodes(nodemask_t nodes, const unsigned long __user nmask,
		nodes_clear(*nodes);
		if (maxnode == 0 \|\| !nmask)
		return 0;
		if (maxnode > PAGE_SIZE)
		if (maxnode > PAGE_SIZE*BITS_PER_BYTE)
		return -EINVAL;

		nlongs = BITS_TO_LONGS(maxnode);