Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9b2e917 authored by Pete Zaitcev's avatar Pete Zaitcev Committed by Linus Torvalds
Browse files

[PATCH] USB: hidinput_hid_event() oops fix 



It seems that I see a bug in hidinput_hid_event.  The check for NULL can never
work, becaue &hidinput->input is nonzero at all times.

Cc: <vojtech@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 498f78e6

drivers/usb/input/hid-input.c

+3 −2
Original line number Diff line number Diff line
@@ -398,11 +398,12 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel 


void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct hid_usage *usage, __s32 value, struct pt_regs *regs)

{

	struct input_dev *input = &field->hidinput->input;

	struct input_dev *input;

	int *quirks = &hid->quirks;



	if (!input)

	if (!field->hidinput)

		return;

	input = &field->hidinput->input;



	input_regs(input, regs);