Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9710ba0 authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Support full source file paths for srcline 



For perf report/script srcline currently only the base file name of the
source file is printed. This is a good default because it usually fits
on the screen.

But in some cases we want to know the full file name, for example to
aggregate hits per file.

In the later case we need more than the base file name to resolve file
naming collisions: for example the kernel source has ~70 files named
"core.c"

It's also useful as input to post processing tools which want to point
to the right file.

Add a flag to allow full file name output.

Add an option to perf report/script to enable this option.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1438986245-15191-1-git-send-email-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 076a30c4

tools/perf/Documentation/perf-report.txt

+2 −0
Original line number Diff line number Diff line
@@ -354,6 +354,8 @@ OPTIONS 


	To disable decoding entirely, use --no-itrace.



--full-source-path::

	Show the full path for source files for srcline output.



include::callchain-overhead-calculation.txt[]

tools/perf/Documentation/perf-script.txt

+3 −0
Original line number Diff line number Diff line
@@ -260,6 +260,9 @@ OPTIONS 


	To disable decoding entirely, use --no-itrace.



--full-source-path::

	Show the full path for source files for srcline output.



SEE ALSO

--------

linkperf:perf-record[1], linkperf:perf-script-perl[1],

tools/perf/builtin-report.c

+2 −0
Original line number Diff line number Diff line
@@ -738,6 +738,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused) 
	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",

			    "Instruction Tracing options",

			    itrace_parse_synth_opts),

	OPT_BOOLEAN(0, "full-source-path", &srcline_full_filename,

			"Show full source file name path for source lines"),

	OPT_END()

	};

	struct perf_data_file file = {

tools/perf/builtin-script.c

+2 −0
Original line number Diff line number Diff line
@@ -1653,6 +1653,8 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) 
	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",

			    "Instruction Tracing options",

			    itrace_parse_synth_opts),

	OPT_BOOLEAN(0, "full-source-path", &srcline_full_filename,

			"Show full source file name path for source lines"),

	OPT_END()

	};

	const char * const script_subcommands[] = { "record", "report", NULL };

tools/perf/util/srcline.c

+5 −1
Original line number Diff line number Diff line
@@ -10,6 +10,8 @@ 


#include "symbol.h"



bool srcline_full_filename;



#ifdef HAVE_LIBBFD_SUPPORT



/*
@@ -277,7 +279,9 @@ char *get_srcline(struct dso *dso, u64 addr, struct symbol *sym, 
	if (!addr2line(dso_name, addr, &file, &line, dso))

		goto out;



	if (asprintf(&srcline, "%s:%u", basename(file), line) < 0) {

	if (asprintf(&srcline, "%s:%u",

				srcline_full_filename ? file : basename(file),

				line) < 0) {

		free(file);

		goto out;

	}