Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a930430b authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Remove unnecessary hci_dev_lock/unlock in smp.c 



The mgmt_user_passkey_request and related functions do not do anything
else except read access to hdev->id. This member never changes after the
hdev creation so there is no need to acquire a lock to read it.

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent f0356704

net/bluetooth/smp.c

+0 −4
Original line number Diff line number Diff line
@@ -514,8 +514,6 @@ static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth, 
		set_bit(SMP_FLAG_TK_VALID, &smp->flags);

	}



	hci_dev_lock(hcon->hdev);



	if (method == REQ_PASSKEY)

		ret = mgmt_user_passkey_request(hcon->hdev, &hcon->dst,

						hcon->type, hcon->dst_type);
@@ -528,8 +526,6 @@ static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth, 
						hcon->type, hcon->dst_type,

						passkey, 0);



	hci_dev_unlock(hcon->hdev);



	return ret;

}