Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8c22754 authored by Alexander Aring's avatar Alexander Aring Committed by Trond Myklebust
Browse files

nfs: fix dead code of ipv6_addr_scope 



The correct way to check on IPV6_ADDR_SCOPE_LINKLOCAL is to check with
the ipv6_addr_src_scope function.

Currently this can't be work, because ipv6_addr_scope returns a int with
a mask of IPV6_ADDR_SCOPE_MASK (0x00f0U) and IPV6_ADDR_SCOPE_LINKLOCAL
is 0x02. So the condition is always false.

Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 6ff33b7d

fs/nfs/nfs4filelayoutdev.c

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ same_sockaddr(struct sockaddr *addr1, struct sockaddr *addr2) 
		b6 = (struct sockaddr_in6 *)addr2;



		/* LINKLOCAL addresses must have matching scope_id */

		if (ipv6_addr_scope(&a6->sin6_addr) ==

		if (ipv6_addr_src_scope(&a6->sin6_addr) ==

		    IPV6_ADDR_SCOPE_LINKLOCAL &&

		    a6->sin6_scope_id != b6->sin6_scope_id)

			return false;