Commit a81de207 authored Jul 03, 2013 by Jingoo Han Committed by Linus Torvalds Jul 03, 2013

rtc: rtc-rp5c01: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7f1c2e82

drivers/rtc/rtc-rp5c01.c

+3 −9

Original line number	Diff line number	Diff line
		@@ -251,21 +251,15 @@ static int __init rp5c01_rtc_probe(struct platform_device *dev)

		rtc = devm_rtc_device_register(&dev->dev, "rtc-rp5c01", &rp5c01_rtc_ops,
		THIS_MODULE);
		if (IS_ERR(rtc)) {
		error = PTR_ERR(rtc);
		goto out;
		}
		if (IS_ERR(rtc))
		return PTR_ERR(rtc);
		priv->rtc = rtc;

		error = sysfs_create_bin_file(&dev->dev.kobj, &priv->nvram_attr);
		if (error)
		goto out;
		return error;

		return 0;

		out:
		platform_set_drvdata(dev, NULL);
		return error;
		}

		static int __exit rp5c01_rtc_remove(struct platform_device *dev)