Commit a7def561 authored Dec 15, 2015 by Dan Carpenter Committed by Rafael J. Wysocki Dec 24, 2015

cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()



The "domain" variable needs to be signed for the error handling to work.

Fixes: 8def3103 (cpufreq: arm_big_little: add SCPI interface driver)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 4ef76753

drivers/cpufreq/scpi-cpufreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;

		static struct scpi_dvfs_info scpi_get_dvfs_info(struct device cpu_dev)
		{
		u8 domain = topology_physical_package_id(cpu_dev->id);
		int domain = topology_physical_package_id(cpu_dev->id);

		if (domain < 0)
		return ERR_PTR(-EINVAL);