Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7cd0232 authored May 12, 2008 by Andrew Vasquez Committed by James Bottomley May 15, 2008

[SCSI] qla2xxx: Revert "qla2xxx: Validate mid-layer 'underflow' during check-condition handling."



This reverts commit 8084fe16.
The midlayer should be given the oppotunity to interpret the
check-condition and based on scsi_cmnd->resid determine if a
transfer should be retried or failed.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent d2ba5675

drivers/scsi/qla2xxx/qla_isr.c

+0 −19

Original line number	Diff line number	Diff line
		@@ -1132,25 +1132,6 @@ qla2x00_status_entry(scsi_qla_host_t ha, void pkt)
		break;

		qla2x00_handle_sense(sp, sense_data, sense_len);

		/*
		* In case of a Underrun condition, set both the lscsi
		* status and the completion status to appropriate
		* values.
		*/
		if (resid &&
		((unsigned)(scsi_bufflen(cp) - resid) <
		cp->underflow)) {
		DEBUG2(qla_printk(KERN_INFO, ha,
		"scsi(%ld:%d:%d:%d): Mid-layer underflow "
		"detected (%x of %x bytes)...returning "
		"error status.\n", ha->host_no,
		cp->device->channel, cp->device->id,
		cp->device->lun, resid,
		scsi_bufflen(cp)));

		cp->result = DID_ERROR << 16 \| lscsi_status;
		}
		} else {
		/*
		* If RISC reports underrun and target does not report