Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a72e1541 authored by Richard Retanubun's avatar Richard Retanubun Committed by David S. Miller
Browse files

of: mdio: fixup of_phy_register_fixed_link parsing of new bindings 



Fixes commit 3be2a49e ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: default avatarRichard Retanubun <rretanubun.work@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 363c2cd6

drivers/of/of_mdio.c

+5 −3
Original line number Diff line number Diff line
@@ -323,11 +323,13 @@ int of_phy_register_fixed_link(struct device_node *np) 
	fixed_link_node = of_get_child_by_name(np, "fixed-link");

	if (fixed_link_node) {

		status.link = 1;

		status.duplex = of_property_read_bool(np, "full-duplex");

		status.duplex = of_property_read_bool(fixed_link_node,

						      "full-duplex");

		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))

			return -EINVAL;

		status.pause = of_property_read_bool(np, "pause");

		status.asym_pause = of_property_read_bool(np, "asym-pause");

		status.pause = of_property_read_bool(fixed_link_node, "pause");

		status.asym_pause = of_property_read_bool(fixed_link_node,

							  "asym-pause");

		of_node_put(fixed_link_node);

		return fixed_phy_register(PHY_POLL, &status, np);

	}