Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6e08fb2 authored Jun 29, 2015 by Markus Elfring Committed by Joerg Roedel Jun 29, 2015

iommu/arm-smmu: Delete an unnecessary check before the function call "free_io_pgtable_ops"



The free_io_pgtable_ops() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent d38f0ff9

drivers/iommu/arm-smmu-v3.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1389,7 +1389,6 @@ static void arm_smmu_domain_free(struct iommu_domain *domain)
	struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);		struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);
	struct arm_smmu_device *smmu = smmu_domain->smmu;		struct arm_smmu_device *smmu = smmu_domain->smmu;

	if (smmu_domain->pgtbl_ops)
	free_io_pgtable_ops(smmu_domain->pgtbl_ops);		free_io_pgtable_ops(smmu_domain->pgtbl_ops);

	/* Free the CD and ASID, if we allocated them */		/* Free the CD and ASID, if we allocated them */