Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a654ddac authored by Damien Cassou's avatar Damien Cassou Committed by Florian Tobias Schandinat
Browse files

drivers/video/msm/mddi_client_nt35399.c: use devm_ functions 



The various devm_ functions allocate memory that is released when a driver
detaches. This patch replaces the use of kzalloc by devm_kzalloc.

Additionally, this patch fixes a memory leak: some memory was allocated for
'panel' but not released when the subsequent call to setup_vsync fails.

Signed-off-by: default avatarDamien Cassou <damien.cassou@lifl.fr>
Acked-by: default avatarDavid Brown <davidb@codeaurora.org>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent b7e69add

drivers/video/msm/mddi_client_nt35399.c

+3 −3
Original line number Diff line number Diff line
@@ -189,7 +189,8 @@ static int mddi_nt35399_probe(struct platform_device *pdev) 


	int ret;



	struct panel_info *panel = kzalloc(sizeof(struct panel_info),

	struct panel_info *panel = devm_kzalloc(&pdev->dev,

						sizeof(struct panel_info),

						GFP_KERNEL);



	printk(KERN_DEBUG "%s: enter.\n", __func__);
@@ -233,7 +234,6 @@ static int mddi_nt35399_remove(struct platform_device *pdev) 
	struct panel_info *panel = platform_get_drvdata(pdev);



	setup_vsync(panel, 0);

	kfree(panel);

	return 0;

}