Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a61400d8 authored by Alexandre Courbot's avatar Alexandre Courbot Committed by Thierry Reding
Browse files

drm/panel: simple: Update calls to gpiod_get*() 



Add the new flags argument to calls of (devm_)gpiod_get*() and remove
any direction setting code afterwards.

Currently both forms (with or without the flags argument) are valid
thanks to transitional macros in <linux/gpio/consumer.h>. These macros
will be removed once all consumers are updated and the flags argument
will become compulsary.

Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Acked-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 26c2ad8a

drivers/gpu/drm/panel/panel-simple.c

+2 −9
Original line number Diff line number Diff line
@@ -247,21 +247,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) 
	if (IS_ERR(panel->supply))

		return PTR_ERR(panel->supply);



	panel->enable_gpio = devm_gpiod_get_optional(dev, "enable");

	panel->enable_gpio = devm_gpiod_get_optional(dev, "enable",

						     GPIOD_OUT_LOW);

	if (IS_ERR(panel->enable_gpio)) {

		err = PTR_ERR(panel->enable_gpio);

		dev_err(dev, "failed to request GPIO: %d\n", err);

		return err;

	}



	if (panel->enable_gpio) {

		err = gpiod_direction_output(panel->enable_gpio, 0);

		if (err < 0) {

			dev_err(dev, "failed to setup GPIO: %d\n", err);

			return err;

		}

	}



	backlight = of_parse_phandle(dev->of_node, "backlight", 0);

	if (backlight) {

		panel->backlight = of_find_backlight_by_node(backlight);