Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5f95da9 authored by Arjun Sreedharan's avatar Arjun Sreedharan Committed by Rafael J. Wysocki
Browse files

ACPI / PNP: Replace faulty is_hex_digit() by isxdigit() 



0 is ascii for NULL. Hex digit matching should be from '0'.
Faulty version returns true for #,$,%,& etc.

Signed-off-by: default avatarArjun Sreedharan <arjun024@gmail.com>
Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent feb41bb1

drivers/acpi/acpi_pnp.c

+2 −6
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 


#include <linux/acpi.h>

#include <linux/module.h>

#include <linux/ctype.h>



static const struct acpi_device_id acpi_pnp_device_ids[] = {

	/* soc_button_array */
@@ -320,11 +321,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = { 
	{""},

};



static bool is_hex_digit(char c)

{

	return (c >= 0 && c <= '9') || (c >= 'A' && c <= 'F');

}



static bool matching_id(char *idstr, char *list_id)

{

	int i;
@@ -335,7 +331,7 @@ static bool matching_id(char *idstr, char *list_id) 
	for (i = 3; i < 7; i++) {

		char c = toupper(idstr[i]);



		if (!is_hex_digit(c)

		if (!isxdigit(c)

		    || (list_id[i] != 'X' && c != toupper(list_id[i])))

			return false;

	}