Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a506d326 authored by Sudarsana Reddy Kalluru's avatar Sudarsana Reddy Kalluru Committed by Greg Kroah-Hartman
Browse files

qede: Prevent index problems in loopback test 




[ Upstream commit afe981d664aeeebc8d1bcbd7d2070b5432edaecb ]

Driver currently utilizes the same loop variable in two
nested loops.

Signed-off-by: default avatarSudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f6a72741

drivers/net/ethernet/qlogic/qede/qede_ethtool.c

+3 −3
Original line number Diff line number Diff line
@@ -1221,7 +1221,7 @@ static int qede_selftest_receive_traffic(struct qede_dev *edev) 
	struct qede_rx_queue *rxq = NULL;

	struct sw_rx_data *sw_rx_data;

	union eth_rx_cqe *cqe;

	int i, rc = 0;

	int i, iter, rc = 0;

	u8 *data_ptr;



	for_each_queue(i) {
@@ -1240,7 +1240,7 @@ static int qede_selftest_receive_traffic(struct qede_dev *edev) 
	 * enabled. This is because the queue 0 is configured as the default

	 * queue and that the loopback traffic is not IP.

	 */

	for (i = 0; i < QEDE_SELFTEST_POLL_COUNT; i++) {

	for (iter = 0; iter < QEDE_SELFTEST_POLL_COUNT; iter++) {

		if (!qede_has_rx_work(rxq)) {

			usleep_range(100, 200);

			continue;
@@ -1287,7 +1287,7 @@ static int qede_selftest_receive_traffic(struct qede_dev *edev) 
		qed_chain_recycle_consumed(&rxq->rx_comp_ring);

	}



	if (i == QEDE_SELFTEST_POLL_COUNT) {

	if (iter == QEDE_SELFTEST_POLL_COUNT) {

		DP_NOTICE(edev, "Failed to receive the traffic\n");

		return -1;

	}