Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4a83100 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: fix port release 



We should not call kill_traffic (and usb_kill_urb) once disconnect
returns. Any pending urbs are killed at disconnect and new submissions
are prevented by usb_unbind_interface (and usb_disable_interface).

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 30d9d42e

drivers/usb/serial/usb-serial.c

+0 −7
Original line number Diff line number Diff line
@@ -572,13 +572,6 @@ static void port_release(struct device *dev) 


	dev_dbg(dev, "%s\n", __func__);



	/*

	 * Stop all the traffic before cancelling the work, so that

	 * nobody will restart it by calling usb_serial_port_softint.

	 */

	kill_traffic(port);

	cancel_work_sync(&port->work);



	usb_free_urb(port->interrupt_in_urb);

	usb_free_urb(port->interrupt_out_urb);

	for (i = 0; i < ARRAY_SIZE(port->read_urbs); ++i) {