Commit a4a0acf8 authored Jan 13, 2009 by Suresh Siddha Committed by Ingo Molnar Jan 14, 2009

x86: fix broken flush_tlb_others_ipi()



This commit broke flush_tlb_others_ipi() causing boot hangs on a
16 logical cpu system:

>	commit 4595f962
>	Author: Rusty Russell <rusty@rustcorp.com.au>
>	Date:   Sat Jan 10 21:58:09 2009 -0800
>
>	    x86: change flush_tlb_others to take a const struct cpumask

This change resulted in sending the invalidate tlb vector to the
sender itself causing the hang. flush_tlb_others_ipi() should exclude
the sender itself from the destination list.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 28e08861

arch/x86/kernel/tlb_64.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -188,7 +188,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask,
	* We have to send the IPI only to		* We have to send the IPI only to
	* CPUs affected.		* CPUs affected.
	*/		*/
	send_IPI_mask(cpumask, INVALIDATE_TLB_VECTOR_START + sender);		send_IPI_mask(f->flush_cpumask, INVALIDATE_TLB_VECTOR_START + sender);

	while (!cpumask_empty(to_cpumask(f->flush_cpumask)))		while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
	cpu_relax();		cpu_relax();