Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a308d66f authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Herbert Xu
Browse files

hwrng: omap - remove #ifdefery around PM methods 



Instead of using #ifdefs let's mark suspend and resume methods as
__maybe_unused which will suppress compiler warnings about them being
unused and provide better compile coverage.

Because SIMPLE_DEV_PM_OPS() produces an empty omap_rng_pm structure in
case of !CONFIG_PM_SLEEP neither omap_rng_suspend nor omap_rng_resume
will end up being referenced and the change will not result in
increasing image size.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f1e866b1

drivers/char/hw_random/omap-rng.c

+3 −12
Original line number Diff line number Diff line
@@ -422,9 +422,7 @@ static int omap_rng_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP



static int omap_rng_suspend(struct device *dev)

static int __maybe_unused omap_rng_suspend(struct device *dev)

{

	struct omap_rng_dev *priv = dev_get_drvdata(dev);
@@ -434,7 +432,7 @@ static int omap_rng_suspend(struct device *dev) 
	return 0;

}



static int omap_rng_resume(struct device *dev)

static int __maybe_unused omap_rng_resume(struct device *dev)

{

	struct omap_rng_dev *priv = dev_get_drvdata(dev);
@@ -445,18 +443,11 @@ static int omap_rng_resume(struct device *dev) 
}



static SIMPLE_DEV_PM_OPS(omap_rng_pm, omap_rng_suspend, omap_rng_resume);

#define	OMAP_RNG_PM	(&omap_rng_pm)



#else



#define	OMAP_RNG_PM	NULL



#endif



static struct platform_driver omap_rng_driver = {

	.driver = {

		.name		= "omap_rng",

		.pm		= OMAP_RNG_PM,

		.pm		= &omap_rng_pm,

		.of_match_table = of_match_ptr(omap_rng_of_match),

	},

	.probe		= omap_rng_probe,