Commit a2e78cf7 authored Jul 11, 2015 by Marc Kleine-Budde

can: slcan: don't touch skb after netif_rx_ni()



There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 83537b6f

drivers/net/can/slcan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -218,10 +218,10 @@ static void slc_bump(struct slcan *sl)

		memcpy(skb_put(skb, sizeof(struct can_frame)),
		&cf, sizeof(struct can_frame));
		netif_rx_ni(skb);

		sl->dev->stats.rx_packets++;
		sl->dev->stats.rx_bytes += cf.can_dlc;
		netif_rx_ni(skb);
		}

		/* parse tty input stream */