Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2d7222f authored by Vlad Drukker's avatar Vlad Drukker Committed by David S. Miller
Browse files

[NETFILTER] {ip,nf}_conntrack TCP: Accept SYN+PUSH like SYN 



Some devices (e.g. Qlogic iSCSI HBA hardware like QLA4010 up to firmware
3.0.0.4) initiates TCP with SYN and PUSH flags set.

The Linux TCP/IP stack deals fine with that, but the connection tracking
code doesn't.

This patch alters TCP connection tracking to accept SYN+PUSH as a valid
flag combination.

Signed-off-by: default avatarVlad Drukker <vlad@storewiz.com>
Signed-off-by: default avatarHarald Welte <laforge@netfilter.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent efacfbcb

net/ipv4/netfilter/ip_conntrack_proto_tcp.c

+1 −0
Original line number Diff line number Diff line
@@ -814,6 +814,7 @@ static u8 tcp_valid_flags[(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG) + 1] = 
{

	[TH_SYN]			= 1,

	[TH_SYN|TH_ACK]			= 1,

	[TH_SYN|TH_PUSH]		= 1,

	[TH_SYN|TH_ACK|TH_PUSH]		= 1,

	[TH_RST]			= 1,

	[TH_RST|TH_ACK]			= 1,

net/netfilter/nf_conntrack_proto_tcp.c

+1 −0
Original line number Diff line number Diff line
@@ -779,6 +779,7 @@ static u8 tcp_valid_flags[(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG) + 1] = 
{

	[TH_SYN]			= 1,

	[TH_SYN|TH_ACK]			= 1,

	[TH_SYN|TH_PUSH]		= 1,

	[TH_SYN|TH_ACK|TH_PUSH]		= 1,

	[TH_RST]			= 1,

	[TH_RST|TH_ACK]			= 1,