Commit a246b819 authored Jun 09, 2016 by Vignesh R Committed by Linus Walleij Jun 13, 2016

gpio: pca953x: Fix NBANK calculation for PCA9536



NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
hence results in 0 banks for PCA9536 which has just 4 gpios. This is
wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
NBANK().

Cc: stable@vger.kernel.org
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c0d30ecf

drivers/gpio/gpio-pca953x.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,7 @@ MODULE_DEVICE_TABLE(acpi, pca953x_acpi_ids);
		#define MAX_BANK 5
		#define BANK_SZ 8

		#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
		#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ)

		struct pca953x_chip {
		unsigned gpio_start;