Commit a22b4b01 authored Jun 23, 2014 by Rik van Riel Committed by Ingo Molnar Jul 05, 2014

sched/numa: Change scan period code to match intent



Reading through the scan period code and comment, it appears the
intent was to slow down NUMA scanning when a majority of accesses
are on the local node, specifically a local:remote ratio of 3:1.

However, the code actually tests local / (local + remote), and
the actual cut-off point was around 30% local accesses, well before
a task has actually converged on a node.

Changing the threshold to 7 means scanning slows down when a task
has around 70% of its accesses local, which appears to match the
intent of the code more closely.

Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: mgorman@suse.de
Cc: chegu_vinod@hp.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1403538095-31256-8-git-send-email-riel@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent db015dae

kernel/sched/fair.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1452,12 +1452,12 @@ static void update_numa_active_node_mask(struct numa_group *numa_group)
		/*
		* When adapting the scan rate, the period is divided into NUMA_PERIOD_SLOTS
		* increments. The more local the fault statistics are, the higher the scan
		* period will be for the next scan window. If local/remote ratio is below
		* NUMA_PERIOD_THRESHOLD (where range of ratio is 1..NUMA_PERIOD_SLOTS) the
		* scan period will decrease
		* period will be for the next scan window. If local/(local+remote) ratio is
		* below NUMA_PERIOD_THRESHOLD (where range of ratio is 1..NUMA_PERIOD_SLOTS)
		* the scan period will decrease. Aim for 70% local accesses.
		*/
		#define NUMA_PERIOD_SLOTS 10
		#define NUMA_PERIOD_THRESHOLD 3
		#define NUMA_PERIOD_THRESHOLD 7

		/*
		* Increase the scan period (slow down scanning) if the majority of