Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a21c2ab4 authored by Helmut Schaa's avatar Helmut Schaa Committed by John W. Linville
Browse files

rt2x00: rt2800: update initial SIFS values 



Currently the CCK and OFDM SIFS value is set to 32us. This value is neither
used by the Ralink driver nor specified in 802.11.

Instead of using 10us for CCK SIFS (as defined in 802.11) use 16us like in the
Ralink drivers. And indeed using a SIFS value of 10us breaks connectivity with
11g + CTS protected connections. Add a comment to the code why we don't use 10us
for CCK SIFS value.

The OFDM SIFS value is set to 16us (as defined in 802.11 and also used by the
Ralink drivers).

Signed-off-by: default avatarHelmut Schaa <helmut.schaa@googlemail.com>
Acked-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Acked-by: default avatarGertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9c6dda4e

drivers/net/wireless/rt2x00/rt2800lib.c

+9 −2
Original line number Diff line number Diff line
@@ -1414,9 +1414,16 @@ int rt2800_init_registers(struct rt2x00_dev *rt2x00dev) 


	rt2800_register_write(rt2x00dev, EXP_ACK_TIME, 0x002400ca);



	/*

	 * Usually the CCK SIFS time should be set to 10 and the OFDM SIFS

	 * time should be set to 16. However, the original Ralink driver uses

	 * 16 for both and indeed using a value of 10 for CCK SIFS results in

	 * connection problems with 11g + CTS protection. Hence, use the same

	 * defaults as the Ralink driver: 16 for both, CCK and OFDM SIFS.

	 */

	rt2800_register_read(rt2x00dev, XIFS_TIME_CFG, &reg);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_CCKM_SIFS_TIME, 32);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_OFDM_SIFS_TIME, 32);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_CCKM_SIFS_TIME, 16);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_OFDM_SIFS_TIME, 16);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_OFDM_XIFS_TIME, 4);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_EIFS, 314);

	rt2x00_set_field32(&reg, XIFS_TIME_CFG_BB_RXEND_ENABLE, 1);