Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1eb96a2 authored by Zhang Rui's avatar Zhang Rui Committed by Len Brown
Browse files

ACPI video hotkey: remove invalid events handler for video output devices 



Both ACPI_VIDEO_NOTIFY_SWITCH and ACPI_VIDEO_NOTIFY_PROBE
are valid for video bus devices only. Actually ACPI video output
device should never be notified for a output device switch/probe.

ACPI bus devices notify handler already has the code to
handle these kinds of events.

Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent a7ecd1ea

drivers/acpi/video.c

+0 −4
Original line number Diff line number Diff line
@@ -1813,10 +1813,6 @@ static void acpi_video_device_notify(acpi_handle handle, u32 event, void *data) 
	device = video_device->dev;



	switch (event) {

	case ACPI_VIDEO_NOTIFY_SWITCH:	/* change in status (cycle output device) */

	case ACPI_VIDEO_NOTIFY_PROBE:	/* change in status (output device status) */

		acpi_bus_generate_event(device, event, 0);

		break;

	case ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS:	/* Cycle brightness */

	case ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS:	/* Increase brightness */

	case ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS:	/* Decrease brightness */