Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1bd8869 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: digi_acceleport.c: remove dbg() tracing calls 



dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Peter Berger <pberger@brimson.com>
CC: Al Borchers <alborchers@steinerpoint.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 108feb66

drivers/usb/serial/digi_acceleport.c

+0 −25
Original line number Diff line number Diff line
@@ -657,9 +657,6 @@ static void digi_rx_throttle(struct tty_struct *tty) 
	struct usb_serial_port *port = tty->driver_data;

	struct digi_port *priv = usb_get_serial_port_data(port);





	dbg("digi_rx_throttle: TOP: port=%d", priv->dp_port_num);



	/* stop receiving characters by not resubmitting the read urb */

	spin_lock_irqsave(&priv->dp_port_lock, flags);

	priv->dp_throttled = 1;
@@ -675,8 +672,6 @@ static void digi_rx_unthrottle(struct tty_struct *tty) 
	struct usb_serial_port *port = tty->driver_data;

	struct digi_port *priv = usb_get_serial_port_data(port);



	dbg("digi_rx_unthrottle: TOP: port=%d", priv->dp_port_num);



	spin_lock_irqsave(&priv->dp_port_lock, flags);



	/* restart read chain */
@@ -904,8 +899,6 @@ static int digi_tiocmget(struct tty_struct *tty) 
	unsigned int val;

	unsigned long flags;



	dbg("%s: TOP: port=%d", __func__, priv->dp_port_num);



	spin_lock_irqsave(&priv->dp_port_lock, flags);

	val = priv->dp_modem_signals;

	spin_unlock_irqrestore(&priv->dp_port_lock, flags);
@@ -921,8 +914,6 @@ static int digi_tiocmset(struct tty_struct *tty, 
	unsigned int val;

	unsigned long flags;



	dbg("%s: TOP: port=%d", __func__, priv->dp_port_num);



	spin_lock_irqsave(&priv->dp_port_lock, flags);

	val = (priv->dp_modem_signals & ~clear) | set;

	spin_unlock_irqrestore(&priv->dp_port_lock, flags);
@@ -1013,8 +1004,6 @@ static void digi_write_bulk_callback(struct urb *urb) 
	int ret = 0;

	int status = urb->status;



	dbg("digi_write_bulk_callback: TOP, status=%d", status);



	/* port and serial sanity check */

	if (port == NULL || (priv = usb_get_serial_port_data(port)) == NULL) {

		pr_err("%s: port or port->private is NULL, status=%d\n",
@@ -1121,8 +1110,6 @@ static int digi_open(struct tty_struct *tty, struct usb_serial_port *port) 
	struct digi_port *priv = usb_get_serial_port_data(port);

	struct ktermios not_termios;



	dbg("digi_open: TOP: port=%d", priv->dp_port_num);



	/* be sure the device is started up */

	if (digi_startup_device(port->serial) != 0)

		return -ENXIO;
@@ -1160,8 +1147,6 @@ static void digi_close(struct usb_serial_port *port) 
	unsigned char buf[32];

	struct digi_port *priv = usb_get_serial_port_data(port);



	dbg("digi_close: TOP: port=%d", priv->dp_port_num);



	mutex_lock(&port->serial->disc_mutex);

	/* if disconnected, just clear flags */

	if (port->serial->disconnected)
@@ -1220,7 +1205,6 @@ static void digi_close(struct usb_serial_port *port) 
	wake_up_interruptible(&priv->dp_close_wait);

	spin_unlock_irq(&priv->dp_port_lock);

	mutex_unlock(&port->serial->disc_mutex);

	dbg("digi_close: done");

}
@@ -1269,8 +1253,6 @@ static int digi_startup(struct usb_serial *serial) 
	struct digi_port *priv;

	struct digi_serial *serial_priv;



	dbg("digi_startup: TOP");



	/* allocate the private data structures for all ports */

	/* number of regular ports + 1 for the out-of-band port */

	for (i = 0; i < serial->type->num_ports + 1; i++) {
@@ -1325,7 +1307,6 @@ static int digi_startup(struct usb_serial *serial) 
static void digi_disconnect(struct usb_serial *serial)

{

	int i;

	dbg("digi_disconnect: TOP, in_interrupt()=%ld", in_interrupt());



	/* stop reads and writes on all ports */

	for (i = 0; i < serial->type->num_ports + 1; i++) {
@@ -1338,7 +1319,6 @@ static void digi_disconnect(struct usb_serial *serial) 
static void digi_release(struct usb_serial *serial)

{

	int i;

	dbg("digi_release: TOP, in_interrupt()=%ld", in_interrupt());



	/* free the private data structures for all ports */

	/* number of regular ports + 1 for the out-of-band port */
@@ -1356,8 +1336,6 @@ static void digi_read_bulk_callback(struct urb *urb) 
	int ret;

	int status = urb->status;



	dbg("digi_read_bulk_callback: TOP");



	/* port sanity check, do not resubmit if port is not valid */

	if (port == NULL)

		return;
@@ -1507,9 +1485,6 @@ static int digi_read_oob_callback(struct urb *urb) 
	int i;

	unsigned int rts;



	dbg("digi_read_oob_callback: port=%d, len=%d",

			priv->dp_port_num, urb->actual_length);



	/* handle each oob command */

	for (i = 0; i < urb->actual_length - 3;) {

		opcode = ((unsigned char *)urb->transfer_buffer)[i++];