Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1bc07c5 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: Don't export internal module variables 



Drivers really have no business touching these. Noticed because
exynose _did_ touch the vblank off delay, which could potentially
affect other drivers.

drm_debug is an exception since it's used in macros and inline
functions.

Note that this reduces the timeout on exynos from 50s to 5s.
Apparently this was done to paper over a vblank get/put race in
exynos, but really should be fixed properly somewhere else. Spotted by
David.

v2: Drop bonghits changes. Note to self: Don't submit patches
before first coffee.

Cc: Inki Dae <inki.dae@samsung.com>
Reviewed-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent bc1dfff0

drivers/gpu/drm/drm_stub.c

+0 −4
Original line number Diff line number Diff line
@@ -38,17 +38,13 @@ unsigned int drm_debug = 0; /* 1 to enable debug output */ 
EXPORT_SYMBOL(drm_debug);



unsigned int drm_rnodes = 0;	/* 1 to enable experimental render nodes API */

EXPORT_SYMBOL(drm_rnodes);



/* 1 to allow user space to request universal planes (experimental) */

unsigned int drm_universal_planes = 0;

EXPORT_SYMBOL(drm_universal_planes);



unsigned int drm_vblank_offdelay = 5000;    /* Default to 5000 msecs. */

EXPORT_SYMBOL(drm_vblank_offdelay);



unsigned int drm_timestamp_precision = 20;  /* Default to 20 usecs. */

EXPORT_SYMBOL(drm_timestamp_precision);



/*

 * Default to use monotonic timestamps for wait-for-vblank and page-flip

drivers/gpu/drm/exynos/exynos_drm_drv.c

+0 −4
Original line number Diff line number Diff line
@@ -39,8 +39,6 @@ 
#define DRIVER_MAJOR	1

#define DRIVER_MINOR	0



#define VBLANK_OFF_DELAY	50000



static struct platform_device *exynos_drm_pdev;



static DEFINE_MUTEX(drm_component_lock);
@@ -103,8 +101,6 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags) 
	/* setup possible_clones. */

	exynos_drm_encoder_setup(dev);



	drm_vblank_offdelay = VBLANK_OFF_DELAY;



	platform_set_drvdata(dev->platformdev, dev);



	/* Try to bind all sub drivers. */

drivers/gpu/drm/exynos/exynos_drm_drv.h

+0 −2
Original line number Diff line number Diff line
@@ -40,8 +40,6 @@ struct drm_device; 
struct exynos_drm_overlay;

struct drm_connector;



extern unsigned int drm_vblank_offdelay;



/* This enumerates device type. */

enum exynos_drm_device_type {

	EXYNOS_DEVICE_TYPE_NONE,