Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1932edf authored by Kim, Milo's avatar Kim, Milo Committed by Bryan Wu
Browse files

leds-lp8788: fix a parent device in _probe() 



The lp8788-keyled is a platform driver of lp8788-mfd. The platform
device is allocated when mfd_add_devices() is called in lp8788-mfd.
On the other hand, 'lp->dev' is the i2c client device.

Therefore, this 'platform_device' is a proper parent device in case
of resource managed mem alloc, registering led device and device
kernel messages.

Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
parent 08541cbc

drivers/leds/leds-lp8788.c

+5 −4
Original line number Diff line number Diff line
@@ -130,9 +130,10 @@ static int lp8788_led_probe(struct platform_device *pdev) 
	struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent);

	struct lp8788_led_platform_data *led_pdata;

	struct lp8788_led *led;

	struct device *dev = &pdev->dev;

	int ret;



	led = devm_kzalloc(lp->dev, sizeof(struct lp8788_led), GFP_KERNEL);

	led = devm_kzalloc(dev, sizeof(struct lp8788_led), GFP_KERNEL);

	if (!led)

		return -ENOMEM;
@@ -154,13 +155,13 @@ static int lp8788_led_probe(struct platform_device *pdev) 


	ret = lp8788_led_init_device(led, led_pdata);

	if (ret) {

		dev_err(lp->dev, "led init device err: %d\n", ret);

		dev_err(dev, "led init device err: %d\n", ret);

		return ret;

	}



	ret = led_classdev_register(lp->dev, &led->led_dev);

	ret = led_classdev_register(dev, &led->led_dev);

	if (ret) {

		dev_err(lp->dev, "led register err: %d\n", ret);

		dev_err(dev, "led register err: %d\n", ret);

		return ret;

	}