Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a192491a authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Jeff Garzik
Browse files

[PATCH] Array overrun in drivers/net/wireless/wavelan.c 



hi,

this is another array overrun spotted by coverity (#id 507)
we should check the index against array size before using it.
Not sure why the driver doesnt use ARRAY_SIZE instead of its
own macro.

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent da4f5ccf

drivers/net/wireless/wavelan.c

+2 −2
Original line number Diff line number Diff line
@@ -1695,8 +1695,8 @@ static int wv_frequency_list(unsigned long ioaddr, /* I/O port of the card */ 
		/* Look in the table if the frequency is allowed */

		if (table[9 - (freq / 16)] & (1 << (freq % 16))) {

			/* Compute approximate channel number */

			while ((((channel_bands[c] >> 1) - 24) < freq) &&

			       (c < NELS(channel_bands)))

			while ((c < NELS(channel_bands)) &&

				(((channel_bands[c] >> 1) - 24) < freq)) 

				c++;

			list[i].i = c;	/* Set the list index */