Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a18069c1 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

amdkfd: Disable support for 32-bit user processes 



This patch checks if the process that opens the /dev/kfd device is 32-bit
process. If so, it returns -EPERM and prints a warning message in dmesg.

This is done to prevent 32-bit user processes from using amdkfd, and hence, HSA
features.

AMD's HSA userspace stack will also support only 64-bit processes on Linux.

Reviewed-by: default avatarAlexey Skidanov <alexey.skidanov@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@amd.com>
parent 7608867d

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+12 −1
Original line number Diff line number Diff line
@@ -102,15 +102,26 @@ struct device *kfd_chardev(void) 
static int kfd_open(struct inode *inode, struct file *filep)

{

	struct kfd_process *process;

	bool is_32bit_user_mode;



	if (iminor(inode) != 0)

		return -ENODEV;



	is_32bit_user_mode = is_compat_task();



	if (is_32bit_user_mode == true) {

		dev_warn(kfd_device,

			"Process %d (32-bit) failed to open /dev/kfd\n"

			"32-bit processes are not supported by amdkfd\n",

			current->pid);

		return -EPERM;

	}



	process = kfd_create_process(current);

	if (IS_ERR(process))

		return PTR_ERR(process);



	process->is_32bit_user_mode = is_compat_task();

	process->is_32bit_user_mode = is_32bit_user_mode;



	dev_dbg(kfd_device, "process %d opened, compat mode (32 bit) - %d\n",

		process->pasid, process->is_32bit_user_mode);