Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a123c52b authored by Steven Rostedt's avatar Steven Rostedt
Browse files

tracing: fix comments about trace buffer resizing 



Impact: cleanup

Some of the comments about the trace buffer resizing is gobbledygook.
And I wonder why people question if I'm a native English speaker.

This patch makes the comments make a bit more sense.

Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarSteven Rostedt <srostedt@redhat.com>
parent 51b643b4

kernel/trace/trace.c

+16 −3
Original line number Diff line number Diff line
@@ -2336,7 +2336,8 @@ static int tracing_resize_ring_buffer(unsigned long size) 


	/*

	 * If kernel or user changes the size of the ring buffer

	 * it get completed.

	 * we use the size that was given, and we can forget about

	 * expanding it later.

	 */

	ring_buffer_expanded = 1;
@@ -2351,8 +2352,20 @@ static int tracing_resize_ring_buffer(unsigned long size) 
		r = ring_buffer_resize(global_trace.buffer,

				       global_trace.entries);

		if (r < 0) {

			/* AARGH! We are left with different

			 * size max buffer!!!! */

			/*

			 * AARGH! We are left with different

			 * size max buffer!!!!

			 * The max buffer is our "snapshot" buffer.

			 * When a tracer needs a snapshot (one of the

			 * latency tracers), it swaps the max buffer

			 * with the saved snap shot. We succeeded to

			 * update the size of the main buffer, but failed to

			 * update the size of the max buffer. But when we tried

			 * to reset the main buffer to the original size, we

			 * failed there too. This is very unlikely to

			 * happen, but if it does, warn and kill all

			 * tracing.

			 */

			WARN_ON(1);

			tracing_disabled = 1;

		}