Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0ffe4c0 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Mauro Carvalho Chehab
Browse files

[media] radio-si470x-usb: use USB API functions rather than constants 



This patch introduces the use of the function usb_endpoint_is_int_in.

The Coccinelle semantic patch that makes these changes is as follows:

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_INT\|3\))
+ usb_endpoint_xfer_int(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- (usb_endpoint_xfer_int(epd) && usb_endpoint_dir_in(epd))
+ usb_endpoint_is_int_in(epd)

Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 3b60b761

drivers/media/radio/si470x/radio-si470x-usb.c

+1 −3
Original line number Diff line number Diff line
@@ -607,9 +607,7 @@ static int si470x_usb_driver_probe(struct usb_interface *intf, 
	/* Set up interrupt endpoint information. */

	for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {

		endpoint = &iface_desc->endpoint[i].desc;

		if (((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ==

		 USB_DIR_IN) && ((endpoint->bmAttributes &

		 USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_INT))

		if (usb_endpoint_is_int_in(endpoint))

			radio->int_in_endpoint = endpoint;

	}

	if (!radio->int_in_endpoint) {